Umbraco CMS

Edited Issue: Duplicate Key error on all Edit In Canvas requests - Kills Entire Public Site [30740]

santanaf — Wed, 22 Feb 2012 19:15:58 GMT

This issue deals with Umbraco 4.7 and a bug that is initiated when edit in canvas is selected and causes the rest of the site to crash for all requests until app pool restart.

We uncovered an issue in our installation that only appeared when a user selected the "Edit in Canvas" option. Once this option was selected, a Duplicate Key error appeared and rendered the public side of the website useless until the application pool was recycled.

Here's the actual error:
Full Error Information:
System.ArgumentException: Item has already been added. Key in dictionary: 'pageName' Key being added: 'pageName'
at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
at umbraco.page..ctor(Int32 Id, Guid Version) in e:\Builds\1\Umbraco\Umbraco - Assembly and Deployment Build\Sources\Trunk\umbraco\presentation\page.cs:line 73

Not sure what the issue is, or why this was occurring. I don't have any duplicate items in our templates or pages, perhaps it is a reserved item. Anyhow, the error should not be so severe and catastrophic as to render the website unusable until the app pool is reset.

The fix to resolve this issue is simple. Line 73 of page.cs in Umbraco.presentation should be altered to add an if statement to check for the existence of the key before attempting to insert the item.

if (!elements.ContainsKey(p.PropertyType.Alias))
elements.Add(p.PropertyType.Alias, sValue);

Simple enough to handle this issue a bit more gracefully.

Similar issues have been identified on forum pages over the years:
http://our.umbraco.org/forum/using/ui-questions/15077-Umbraco-Dictionairy-Error-Item-has-already-been-added-
http://forum.umbraco.org/yaf_postst7692_Nested-Document-Types-Master-Docs.aspx

Created Issue: Duplicate Key error on all Edit In Canvas requests - Kills Entire Public Site [30740]

santanaf — Wed, 22 Feb 2012 19:09:16 GMT

Commented Issue: Item has already been added. Key in dictionary: 85 Key being added 85 [30472]

neehouse — Wed, 22 Feb 2012 01:09:57 GMT

Sometimes when editing a node the page will throw exceptions until the app is restarted.

System.Web.HttpUnhandledException (0x80004005): Exception of type 'System.Web.HttpUnhandledException' was thrown. ---> System.ArgumentException: Item has already been added. Key in dictionary: '85' Key being added: '85'
at umbraco.controls.ContentControl.CreateChildControls()
at System.Web.UI.Control.EnsureChildControls()
at umbraco.controls.ContentControl.OnInit(EventArgs e)
at System.Web.UI.Control.InitRecursive(Control namingContainer)
at System.Web.UI.Control.AddedControl(Control control, Int32 index)
at umbraco.cms.presentation.editContent.OnInit(EventArgs e)
at System.Web.UI.Control.InitRecursive(Control namingContainer)
at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
at System.Web.UI.Page.HandleError(Exception e)
at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
at System.Web.UI.Page.ProcessRequest(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
at System.Web.UI.Page.ProcessRequest()
at System.Web.UI.Page.ProcessRequest(HttpContext context)
at System.Web.HttpApplication.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute()
at System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)
Comments: Fixed in Commit bbb329c3c80f

Edited Issue: Item has already been added. Key in dictionary: 85 Key being added 85 [30472]

neehouse — Wed, 22 Feb 2012 01:09:57 GMT

Created Issue: V5 document is lacking. [30739]

naturalwalker — Tue, 21 Feb 2012 22:21:25 GMT

Though we can look into the source code for everything for now, it is still the try and error method. If only the document can keep up with the aggressive developing.

Created Issue: Single Quote in Role Name [30738]

TonyCooke — Mon, 20 Feb 2012 22:20:53 GMT

I apologise for the cross post (http://our.umbraco.org/forum/ourumb-dev-forum/bugs/28897-Single-Quote-in-Role-Name) but I'm hoping this is a quick fix as similar issues have appeared in the past and have been resolved.

I'm using Umbraco 4.7.0 and have also now tested the scenario under 4.7.1.1 with the same results.

I have implemented custom Membership, Profile and Role providers for our environment and they appear to be working correctly.

The issue I face is when I change the "Public Access" for a node to use a custom role from the Role Provider and the role name contains a single quote (for example, "All Mazzucchelli's ACT") I get the following exception (using 4.7.0):

Exception information: Exception type: XPathException Exception message: './group [@id='All Mazzucchelli's ACT']' has an invalid token. at MS.Internal.Xml.XPath.XPathParser.CheckToken(LexKind t) at MS.Internal.Xml.XPath.XPathParser.ParsePredicate(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseStep(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseRelativeLocationPath(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseRelativeLocationPath(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseLocationPath(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParsePathExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseUnionExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseUnaryExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseMultiplicativeExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseAdditiveExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseRelationalExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseEqualityExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseAndExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseOrExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseXPathExpresion(String xpathExpresion) at System.Xml.XPath.XPathExpression.Compile(String xpath, IXmlNamespaceResolver nsResolver) at System.Xml.XPath.XPathNavigator.Select(String xpath) at System.Xml.XmlNode.SelectNodes(String xpath) at System.Xml.XmlNode.SelectSingleNode(String xpath) at umbraco.cms.businesslogic.web.Access.IsProtectedByMembershipRole(Int32 documentId, String role) at umbraco.presentation.umbraco.dialogs.protectPage.Page_Load(Object sender, EventArgs e) at System.Web.Util.CalliHelper.EventArgFunctionCaller(IntPtr fp, Object o, Object t, EventArgs e) at System.Web.Util.CalliEventHandlerDelegateProxy.Callback(Object sender, EventArgs e) at System.EventHandler.Invoke(Object sender, EventArgs e) at System.Web.UI.Control.OnLoad(EventArgs e) at umbraco.BasePages.BasePage.OnLoad(EventArgs e) at System.Web.UI.Control.LoadRecursive() at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)

It's obvious that the single quote has not been escaped.

Do I need to provide the escaped name (which is coming from active directory and is unable to be changed) or is this internal?

This is the exception but for 4.7.1.1:

Exception information: Exception type: XPathException Exception message: 'group [@id = 'All Mazzucchelli's ACT']' has an invalid token. at MS.Internal.Xml.XPath.XPathParser.CheckToken(LexKind t) at MS.Internal.Xml.XPath.XPathParser.ParsePredicate(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseStep(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseRelativeLocationPath(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseLocationPath(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParsePathExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseUnionExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseUnaryExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseMultiplicativeExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseAdditiveExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseRelationalExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseEqualityExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseAndExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseOrExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseXPathExpresion(String xpathExpresion) at System.Xml.XPath.XPathExpression.Compile(String xpath, IXmlNamespaceResolver nsResolver) at System.Xml.XPath.XPathNavigator.Select(String xpath) at System.Xml.XmlNode.SelectNodes(String xpath) at System.Xml.XmlNode.SelectSingleNode(String xpath) at umbraco.cms.businesslogic.web.Access.RemoveMembershipRoleFromDocument(Int32 documentId, String role) at umbraco.presentation.umbraco.dialogs.protectPage.protect_Click(Object sender, CommandEventArgs e) at System.Web.UI.WebControls.Button.OnCommand(CommandEventArgs e) at System.Web.UI.WebControls.Button.RaisePostBackEvent(String eventArgument) at System.Web.UI.WebControls.Button.System.Web.UI.IPostBackEventHandler.RaisePostBackEvent(String eventArgument) at System.Web.UI.Page.RaisePostBackEvent(IPostBackEventHandler sourceControl, String eventArgument) at System.Web.UI.Page.RaisePostBackEvent(NameValueCollection postData) at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)

Request information: Request URL: http://portal:8889/umbraco/dialogs/protectPage.aspx?mode=cut&nodeId=2236&rnd=62.1&rndo=65.2 Request path: /umbraco/dialogs/protectPage.aspx User host address: 192.168.1.208 User: Tony Cooke Is authenticated: True Authentication Type: Forms Thread account name: NT AUTHORITY\NETWORK SERVICE Thread information: Thread ID: 11 Thread account name: NT AUTHORITY\NETWORK SERVICE Is impersonating: False Stack trace: at MS.Internal.Xml.XPath.XPathParser.CheckToken(LexKind t) at MS.Internal.Xml.XPath.XPathParser.ParsePredicate(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseStep(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseRelativeLocationPath(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseLocationPath(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParsePathExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseUnionExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseUnaryExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseMultiplicativeExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseAdditiveExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseRelationalExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseEqualityExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseAndExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseOrExpr(AstNode qyInput) at MS.Internal.Xml.XPath.XPathParser.ParseXPathExpresion(String xpathExpresion) at System.Xml.XPath.XPathExpression.Compile(String xpath, IXmlNamespaceResolver nsResolver) at System.Xml.XPath.XPathNavigator.Select(String xpath) at System.Xml.XmlNode.SelectNodes(String xpath) at System.Xml.XmlNode.SelectSingleNode(String xpath) at umbraco.cms.businesslogic.web.Access.RemoveMembershipRoleFromDocument(Int32 documentId, String role) at umbraco.presentation.umbraco.dialogs.protectPage.protect_Click(Object sender, CommandEventArgs e) at System.Web.UI.WebControls.Button.OnCommand(CommandEventArgs e) at System.Web.UI.WebControls.Button.RaisePostBackEvent(String eventArgument) at System.Web.UI.WebControls.Button.System.Web.UI.IPostBackEventHandler.RaisePostBackEvent(String eventArgument) at System.Web.UI.Page.RaisePostBackEvent(IPostBackEventHandler sourceControl, String eventArgument) at System.Web.UI.Page.RaisePostBackEvent(NameValueCollection postData) at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)0

Thanks you in advance for any help you can offer and I once again apologise for the cross post.

All the best,
Tony

Created Issue: Error while Renaming the DocumentType Alias in 4.7.1.1 using SQL CE [30737]

mvdput — Mon, 20 Feb 2012 14:02:51 GMT

When I try to rename the Alias of a DocumentType in Umbraco 4.7.1.1 using SQL CE 4, it throws an error about the SQL query:

Error running NonQuery:
SQL Statement:
truncate table cmsContentXml

Exception:
System.Data.SqlServerCe.SqlCeException: There was an error parsing the query. [ Token line number = 1,Token line offset = 1,Token in error = truncate ]
at System.Data.SqlServerCe.SqlCeCommand.ProcessResults(Int32 hr)
at System.Data.SqlServerCe.SqlCeCommand.CompileQueryPlan()
at System.Data.SqlServerCe.SqlCeCommand.ExecuteCommand(CommandBehavior behavior, String method, ResultSetOptions options)
at System.Data.SqlServerCe.SqlCeCommand.ExecuteNonQuery()
at SqlCE4Umbraco.SqlCeApplicationBlock.ExecuteNonQuery(String connectionString, CommandType commandType, String commandText, SqlCeParameter[] commandParameters)

Created Issue: Error while copy DocumentType in 4.7.1.1 with SQL CE [30736]

mvdput — Mon, 20 Feb 2012 14:02:06 GMT

When trying to copy a documenttype, I get another error in 4.7.1.1 when using SQL CE:

Error running NonQuery:
SQL Statement:
update cmsContentType set description = @description where nodeId = @id

Exception:
System.ArgumentNullException: Parameterized query 'update cmsContentType set description = @description where nodeId = @id' expects a parameter value which was not supplied.
Parameter name: @description
at System.Data.SqlServerCe.SqlCeCommand.FillParameterDataBindings(Boolean verifyValue)
at System.Data.SqlServerCe.SqlCeCommand.ExecuteCommand(CommandBehavior behavior, String method, ResultSetOptions options)
at System.Data.SqlServerCe.SqlCeCommand.ExecuteNonQuery()
at SqlCE4Umbraco.SqlCeApplicationBlock.ExecuteNonQuery(String connectionString, CommandType commandType, String commandText, SqlCeParameter[] commandParameters)

Commented Issue: Turkish I problem affects Umbraco 4.7 & 5 [30649]

Nime — Sat, 18 Feb 2012 19:39:42 GMT

It seems impossible to install on Turkish version of Windows because of infamous Turkish I problem. Below is the line from trace log:

NHibernate.HibernateException: Wrong column type in AttributeDateValue for column Id. Found: uniqueidentifier, Expected UNIQUEIDENTIFIER

As you see, uppercase & lowercase versions of uniqueidentifier are not equal in Turkish system.

From Microsoft's site:
For nearly all Latin alphabets, including U.S. English, the character i (\u0069) is the lowercase version of the character I (\u0049). This casing rule quickly becomes the default for someone programming in such a culture. However, in Turkish ("tr-TR"), there exists a capital "i with a dot," character (\u0130), which is the capital version of i. Similarly, in Turkish, there is a lowercase "i without a dot," or (\u0131), which capitalizes to I. This behavior occurs in the Azeri culture ("az") as well.
http://msdn.microsoft.com/en-us/library/ms973919.aspx#stringsinnet20_topic5

UPDATE:

I found the reason & location of the bug in NHibernate\Mapping\Table.sc at line 993

bool typesMatch = column.GetSqlType(dialect, mapping).ToLower().StartsWith(columnInfo.TypeName.ToLower());

That line returns false in Turkish environment because of Turkish-I problem. The correct line should be like below:

bool typesMatch = column.GetSqlType(dialect, mapping).ToLowerInvariant().StartsWith(columnInfo.TypeName.ToLowerInvariant());
Comments: Bug fixed in NHibernate 3.2.0, Umbraco should use the latest version of NHibernate.dll.

Commented Issue: Turkish I problem affects Umbraco 4.7 & 5 [30649]

Nime — Sat, 18 Feb 2012 11:19:04 GMT

It seems impossible to install on Turkish version of Windows because of infamous Turkish I problem. Below is the line from trace log:

NHibernate.HibernateException: Wrong column type in AttributeDateValue for column Id. Found: uniqueidentifier, Expected UNIQUEIDENTIFIER

As you see, uppercase & lowercase versions of uniqueidentifier are not equal in Turkish system.

From Microsoft's site:
For nearly all Latin alphabets, including U.S. English, the character i (\u0069) is the lowercase version of the character I (\u0049). This casing rule quickly becomes the default for someone programming in such a culture. However, in Turkish ("tr-TR"), there exists a capital "i with a dot," character (\u0130), which is the capital version of i. Similarly, in Turkish, there is a lowercase "i without a dot," or (\u0131), which capitalizes to I. This behavior occurs in the Azeri culture ("az") as well.
http://msdn.microsoft.com/en-us/library/ms973919.aspx#stringsinnet20_topic5

UPDATE:

I found the reason & location of the bug in NHibernate\Mapping\Table.sc at line 993

bool typesMatch = column.GetSqlType(dialect, mapping).ToLower().StartsWith(columnInfo.TypeName.ToLower());

That line returns false in Turkish environment because of Turkish-I problem. The correct line should be like below:

bool typesMatch = column.GetSqlType(dialect, mapping).ToLowerInvariant().StartsWith(columnInfo.TypeName.ToLowerInvariant());
Comments: I've submitted an issue: https://nhibernate.jira.com/browse/NH-3063

Edited Issue: Turkish I problem affects Umbraco 4.7 & 5 [30649]

Nime — Fri, 17 Feb 2012 22:27:09 GMT

Edited Issue: Turkish I problem affects Umbraco 4.7 & 5 [30649]

Nime — Fri, 17 Feb 2012 21:45:46 GMT

Source code checked in, #b5564227fb03

boxbinary — Fri, 17 Feb 2012 12:20:32 GMT

Merge

Source code checked in, #764c72ac5a59

boxbinary — Fri, 17 Feb 2012 12:20:08 GMT

Improved error reporting on AbstractUserEditorController

Source code checked in, #ae0be53b34e6

mattbrailsford — Fri, 17 Feb 2012 12:17:31 GMT

Added fix for YSOD when creating a new user

Source code checked in, #1dbb67ef73d0

mattbrailsford — Fri, 17 Feb 2012 11:35:23 GMT

Merge

Source code checked in, #ed1e43dc066f

mattbrailsford — Fri, 17 Feb 2012 11:35:15 GMT

Added Member specific create dialog screen

Source code checked in, #55a93ff90213

boxbinary — Fri, 17 Feb 2012 11:32:27 GMT

Merge

Source code checked in, #3e0b56050638

boxbinary — Fri, 17 Feb 2012 11:31:40 GMT

Resolves a YSOD on install, temporary fix: The line in MembershipService: profile.RelationProxies.EnlistParentById(_profileVirtualRootId, FixedRelationTypes.DefaultRelationType); Was causing a RelationProxy to be created where the Destination was not the same object instance as the owner (profile) causing a problem later then adding the relation For now I've changed it to: uow.Repositories.AddRelation(_profileVirtualRootId, profile.Id, FixedRelationTypes.DefaultRelationType, 0);

Source code checked in, #2c7135b0f2c7

mattbrailsford — Fri, 17 Feb 2012 11:00:21 GMT

Fixed issue with inherited member types erroring on re-save